Would an error be more appropriate? Modifying git configuration as a side effect makes me slightly uncomfortable.

Yeah, same, the other problem is that origin is the default so it may be the user's fork.

Usually we instruct people to use "upstream" (the original repo under kubernetes) and "origin" (your fork) as the remotes, but e can't guarantee it.

see also: the apidiff script in kubernetes/kubernetes

typically it would be more polite to use a temporary local GOBIN instead of writing binaries to the system GOBIN

in kubernetes/kubernetes build outputs go under _output/ (which is gitignored) and we create a temp GOBIN under there.

the actual compile cache will be reused from the system but we'll avoid modifying binaries in the real user PATH

Updated with a local GOBIN and output to _output/.

it looks like we also need .gitignore, https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/.gitignore only has .idea

I guess being a library, we don't have a standard build output location yet for this repo

I think it should be fine use delete the created directory after execution.

I think we could add this to a make clean like target instead, if we add other things under _output/bin in the future, this will race on deleting all of them?

We usually have an exit trap for e.g. a tmpdir that is scoped to the lifetime of the script.

I combined all into the cleanup function.

I meant that if we have any other scripts install tools, this script is clobbering the entire fixed gobin, instead we could probably just leave it behind and leave removing it to something like make clean (manually invoked), or we should use a temp path that is specific to this script run. (like mktemp -d under _output)

my suggestion: use the shared tempdir for work scoped to this script run..

create underneath this a gopath and a worktree subdir

use a shared exit trap to remove the whole thing.

you may want to create the tempdir under something like _output, for performance reasons if you're doing worktree etc (otherwise they may be on different filesystems), you can do this with an argument to mktemp

and gitignore _output (or similar), whatever paths we use within the repo that are for builds/intermediate outputs

Thanks for the suggestion, I updated to move things into the shared temp dir under _output